[Mesa-dev] [PATCH 46/53] i965/drm: Fold drm_bacon_gem_reset_stats into the callers.

Chris Wilson chris at chris-wilson.co.uk
Wed Apr 5 11:59:19 UTC 2017


On Tue, Apr 04, 2017 at 05:10:36PM -0700, Kenneth Graunke wrote:

Even a small justification?

I would have kept the bare ioctl wrapper

	static int get_reset_stats(int fd, struct *stats)
	{
		int err;

		err = 0;
		if (drmIoctl(fd, DRM_IOCTL_I915_GET_RESET_STATS, stats))
			err = -errno;

		return err; /* reporting the actual error may be
		               overkill, just habit! */
	}


Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the mesa-dev mailing list