[Mesa-dev] [PATCH 50/53] i965: Drop brw_bo_map[_gtt] wrappers which issue perf warnings.

[Chris Wilson]

On Tue, Apr 04, 2017 at 05:10:40PM -0700, Kenneth Graunke wrote:
> The stupid reason for eliminating these functions is that I'm about
> to rename drm_bacon_bo_map() to brw_bo_map(), which makes the real
> function have the short name, rather than the wrapper.
> 
> I'm also planning on reworking our mapping code soon, so we use WC
> mappings and proper unsynchronized mappings on non-LLC platforms.
> It will be easier to do that without thinking about the stall
> warnings and wrappers.
> 
> My eventual hope is to put the performance warnings in the BO map
> function itself, so all callers gain the warning.

I plumbed your perf_debug into the lower layers to maintain the stall
warnings. Would that not be a better approach?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre