[Mesa-dev] [PATCH 41/53] i965/drm: Merge bo->handle and bo_gem->gem_handle.

[Kenneth Graunke]

On Wednesday, April 5, 2017 4:47:57 AM PDT Chris Wilson wrote:
> On Tue, Apr 04, 2017 at 05:10:31PM -0700, Kenneth Graunke wrote:
> > These fields are the same value.  In the bad old days, bo->handle could
> > have been an identifier from the pre-GEM fake bufmgr, but that's long
> > gone.  Keep the "gem_handle" name for clarity.
> 
> Earlier? Is there a reason why the drm_bacon_bo/drm_bacon_gem_bo has
> remained so long? At the moment they are the same global information.
> 
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> -Chris

I wasn't sure whether or not I wanted to combine them at first...
it does offer a bit of encapsulation, keeping the rest of the driver
from poking at say, BO cache links.  But, after rewriting relocations
and eliminating a ton of fields, and having to poke at a few more...
it just seemed reasonable to merge them.

It would make sense to do earlier, in retrospect.

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170405/ce449855/attachment.sig>