[Mesa-dev] [PATCH v2 1/4] intel/aubinator_error_decode: Fix structure decode data

Matt Turner mattst88 at gmail.com
Thu Apr 6 06:00:20 UTC 2017


On Wed, Apr 5, 2017 at 10:51 PM, Jordan Justen
<jordan.l.justen at intel.com> wrote:
> The call to gen_print_group should provide a pointer to the beginning
> of the the structure data, not the start of the batch data.
>
> Cc: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/intel/tools/aubinator_error_decode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/intel/tools/aubinator_error_decode.c b/src/intel/tools/aubinator_error_decode.c
> index 8a67f4f1698..1bdab00a663 100644
> --- a/src/intel/tools/aubinator_error_decode.c
> +++ b/src/intel/tools/aubinator_error_decode.c
> @@ -239,7 +239,7 @@ static void decode(struct gen_spec *spec,
>        printf("%s0x%08"PRIx64":  0x%08x:  %-80s%s\n",
>               color, offset, p[0], gen_group_get_name(inst), reset_color);
>
> -      gen_print_group(stdout, inst, offset, data,
> +      gen_print_group(stdout, inst, offset, p,
>                        option_color == COLOR_ALWAYS);

Nice. This fixes a bug I was seeing as well.

Reviewed-by: Matt Turner <mattst88 at gmail.com>


More information about the mesa-dev mailing list