[Mesa-dev] [PATCH] egl/wayland: allow building with Wayland 1.10

[Brian Paul]

On 04/06/2017 01:51 PM, Daniel Stone wrote:
> Hi Brian,
>
> On 6 April 2017 at 20:17, Daniel Stone <daniel at fooishbar.org> wrote:
>> On 6 April 2017 at 19:49, Brian Paul <brianp at vmware.com> wrote:
>>> Fedora 24 only has Wayland 1.10, not 1.11.  This change lets us build Mesa/EGL
>>> with Wayland 1.10 on that distro.
>>>
>>> A new wayland-compat.h file has stubs for the wl_proxy_create_wrapper() and
>>> wl_proxy_wrapper_destroy() functions which were added in Wayland 1.11.
>>
>> These stubs are harmful: they introduce bad behaviour in that
>> callbacks for both clients and driver will now be called from
>> arbitrary contexts, and destroy leaks. If we need to build on F24, we
>> need to introduce an #ifdef path such that we create a display wrapper
>> where available, but fall back to calling wl_proxy_set_queue() for
>> every object we create.
>
> A couple of minutes in the shower just now has clarified to me that
> destruction doesn't leak at all. Sorry about that. The
> create_wrapper() bit still needs redoing though, and can't be a 1:1
> translation ...

Thanks for the feedback.  Despite testing looking OK, I figured this 
probably wasn't ideal.

Jonas was the one who did the 1.10 -> 1.11 bump so hopefully he can do a 
proper implementation.

Jonas?

-Brian