[Mesa-dev] [PATCH v2] gbm: add support for loading third-party backend (v2)

Ilia Mirkin imirkin at alum.mit.edu
Fri Apr 7 14:21:14 UTC 2017


On Fri, Apr 7, 2017 at 9:43 AM, Yu, Qiang <Qiang.Yu at amd.com> wrote:
>
>>> +dnl Directory for GBM
>>> +
>>> +AC_ARG_WITH([gbm-configdir],
>>> +    [AS_HELP_STRING([--with-gbm-configdir=DIR],
>>> +        [directory for the GBM configs @<:@/etc/gbm.conf.d@:>@])],
>>> +    [GBM_CONFIG_DIR="$withval"],
>>> +    [GBM_CONFIG_DIR='/etc/gbm.conf.d'])
>>
>> Without commenting on the rest of the change, these should be
>> ${sysconfigdir} instead of /etc.
>
> With ${sysconfigdir} I get /usr/local/etc (${prefix}/etc) by default, seems not a good place.

sysconfigdir is the right place. If you want it to point to /etc, you
should run configure with --with-sysconfigdir=/etc. The point of
--prefix is to make sure that everything's contained within it. Many
distros choose to set the sysconfigdir to /etc, but that doesn't
change the fact that config files should live in sysconfigdir,
whatever it's set to.

  -ilia


More information about the mesa-dev mailing list