[Mesa-dev] [PATCH 1/9] mesa: create _mesa_attach_renderbuffer_without_ref() helper

[Timothy Arceri]

On 08/04/17 11:04, Timothy Arceri wrote:
> This will be used to take ownership of freashly created renderbuffers,
> avoiding the need to call the reference function which requires
> locking.
> ---
>  src/mesa/main/renderbuffer.c | 19 +++++++++++++++++--
>  src/mesa/main/renderbuffer.h |  5 +++++
>  2 files changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/renderbuffer.c b/src/mesa/main/renderbuffer.c
> index 1d24e9c..6fcff35 100644
> --- a/src/mesa/main/renderbuffer.c
> +++ b/src/mesa/main/renderbuffer.c
> @@ -101,24 +101,28 @@ void
>  _mesa_delete_renderbuffer(struct gl_context *ctx, struct gl_renderbuffer *rb)
>  {
>     free(rb->Label);
>     free(rb);
>  }
>
>
>  /**
>   * Attach a renderbuffer to a framebuffer.
>   * \param bufferName  one of the BUFFER_x tokens
> + *
> + * This function avoids adding a reference and is therefore intended to be
> + * used with a freashly created renderbuffer.
>   */
>  void
> -_mesa_add_renderbuffer(struct gl_framebuffer *fb,
> -                       gl_buffer_index bufferName, struct gl_renderbuffer *rb)
> +_mesa_attach_renderbuffer_without_ref(struct gl_framebuffer *fb,

Sorry the subject should have been:

mesa: create _mesa_add_renderbuffer_without_ref() helper

And the renaming of this function was wrongly squashed into the 
following patch. I've fixed these locally.