[Mesa-dev] [PATCH 9/9] nvc0: Enable ARB_shader_ballot on Kepler+

[Ilia Mirkin]

Meh, caution to the wind. It'll be easy to fix when/if someone complains.

On Sat, Apr 8, 2017 at 8:59 AM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> I would just suggest to only enable the feature on GK110 for now. Except if
> someone else can test on GK104 and GM107+.
>
>
> On 04/08/2017 11:51 AM, Boyan Ding wrote:
>>
>> readInvocationARB() and readFirstInvocationARB() need SHFL.IDX
>> instruction which is introduced in Kepler.
>> ---
>>   docs/features.txt                              | 2 +-
>>   docs/relnotes/17.1.0.html                      | 2 +-
>>   src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 ++-
>>   3 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/docs/features.txt b/docs/features.txt
>> index 5cc109036b..505eee4516 100644
>> --- a/docs/features.txt
>> +++ b/docs/features.txt
>> @@ -292,7 +292,7 @@ Khronos, ARB, and OES extensions that are not part of
>> any OpenGL or OpenGL ES ve
>>     GL_ARB_sample_locations                               not started
>>     GL_ARB_seamless_cubemap_per_texture                   DONE (i965,
>> nvc0, radeonsi, r600, softpipe, swr)
>>     GL_ARB_shader_atomic_counter_ops                      DONE
>> (i965/gen7+, nvc0, radeonsi, softpipe)
>> -  GL_ARB_shader_ballot                                  DONE (radeonsi)
>> +  GL_ARB_shader_ballot                                  DONE (nvc0,
>> radeonsi)
>>     GL_ARB_shader_clock                                   DONE
>> (i965/gen7+, radeonsi)
>>     GL_ARB_shader_draw_parameters                         DONE (i965,
>> nvc0, radeonsi)
>>     GL_ARB_shader_group_vote                              DONE (nvc0,
>> radeonsi)
>> diff --git a/docs/relnotes/17.1.0.html b/docs/relnotes/17.1.0.html
>> index 7419970283..10c60a066c 100644
>> --- a/docs/relnotes/17.1.0.html
>> +++ b/docs/relnotes/17.1.0.html
>> @@ -45,7 +45,7 @@ Note: some of the new features are only available with
>> certain drivers.
>>     <ul>
>>   <li>GL_ARB_gpu_shader_int64 on i965/gen8+, nvc0, radeonsi, softpipe,
>> llvmpipe</li>
>> -<li>GL_ARB_shader_ballot on radeonsi</li>
>> +<li>GL_ARB_shader_ballot on nvc0, radeonsi</li>
>>   <li>GL_ARB_shader_clock on radeonsi</li>
>>   <li>GL_ARB_shader_group_vote on radeonsi</li>
>>   <li>GL_ARB_sparse_buffer on radeonsi/CIK+</li>
>> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> index 064848db4a..6a027e9a51 100644
>> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c
>> @@ -258,6 +258,8 @@ nvc0_screen_get_param(struct pipe_screen *pscreen,
>> enum pipe_cap param)
>>         return class_3d >= NVE4_3D_CLASS; /* needs testing on fermi */
>>      case PIPE_CAP_POLYGON_MODE_FILL_RECTANGLE:
>>         return class_3d >= GM200_3D_CLASS;
>> +   case PIPE_CAP_TGSI_BALLOT:
>> +      return class_3d >= NVE4_3D_CLASS;
>>        /* unsupported caps */
>>      case PIPE_CAP_TGSI_FS_COORD_ORIGIN_LOWER_LEFT:
>> @@ -289,7 +291,6 @@ nvc0_screen_get_param(struct pipe_screen *pscreen,
>> enum pipe_cap param)
>>      case PIPE_CAP_INT64_DIVMOD:
>>      case PIPE_CAP_TGSI_CLOCK:
>>      case PIPE_CAP_SPARSE_BUFFER_PAGE_SIZE:
>> -   case PIPE_CAP_TGSI_BALLOT:
>>         return 0;
>>        case PIPE_CAP_VENDOR_ID:
>>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev