[Mesa-dev] [PATCH] amd/addrlib: use correct variable name in header

Edward O'Callaghan funfunctor at folklore1984.net
Mon Apr 10 02:49:08 UTC 2017



On 04/10/2017 12:31 PM, Thomas H.P. Andersen wrote:
> On Sun, Apr 9, 2017 at 8:25 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>>
>> Marek
> 
> Thanks. I do not have commit access, so will need someone to push it for me.
Done, thanks for the fix!
Kind Regards,
Edward.

> 
>> On Sat, Apr 8, 2017 at 8:36 AM, Thomas Hindoe Paaboel Andersen
>> <phomes at gmail.com> wrote:
>>> Since the inclusion in 7f160efcde41b52ad78e562316384373dab419e3
>>> the header used x_biased, while the implementation used y_biased.
>>> This changes the header to macth the implementation since the
>>> uses of the function seems to expect y_biased.
>>> ---
>>>  src/amd/addrlib/gfx9/rbmap.h | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/amd/addrlib/gfx9/rbmap.h b/src/amd/addrlib/gfx9/rbmap.h
>>> index f2f2ca8..89c8922 100644
>>> --- a/src/amd/addrlib/gfx9/rbmap.h
>>> +++ b/src/amd/addrlib/gfx9/rbmap.h
>>> @@ -49,7 +49,7 @@ public:
>>>
>>>      void Get_Comp_Block_Screen_Space( CoordEq& addr, int bytes_log2, int* w, int* h, int* d = NULL);
>>>
>>> -    void Get_Meta_Block_Screen_Space( int num_comp_blocks_log2, bool is_thick, bool x_biased,
>>> +    void Get_Meta_Block_Screen_Space( int num_comp_blocks_log2, bool is_thick, bool y_biased,
>>>                                        int comp_block_width_log2, int comp_block_height_log2, int comp_block_depth_log2,
>>>                                        int& meta_block_width_log2, int& meta_block_height_log2, int& meta_block_depth_log2 );
>>>      void cap_pipe( int xmode, bool is_thick, int& num_ses_log2, int bpp_log2, int num_samples_log2, int pipe_interleave_log2,
>>> --
>>> 2.9.3
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170410/23a6af43/attachment.sig>


More information about the mesa-dev mailing list