[Mesa-dev] [PATCH 5/9] i965/bufmgr: Remove some reuse functions

Kenneth Graunke kenneth at whitecape.org
Mon Apr 10 07:18:50 UTC 2017


From: Daniel Vetter <daniel.vetter at ffwll.ch>

is_reusable was needed by uxa because it couldn't keep track of its
scanout buffers and used this as a proxy. Disabling reuse is a silly
idea, we set this once at start. Remove both.

Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
---
 src/mesa/drivers/dri/i965/brw_bufmgr.c | 17 -----------------
 src/mesa/drivers/dri/i965/brw_bufmgr.h | 16 ----------------
 2 files changed, 33 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.c b/src/mesa/drivers/dri/i965/brw_bufmgr.c
index 080a4bd6f1a..f6f50af1259 100644
--- a/src/mesa/drivers/dri/i965/brw_bufmgr.c
+++ b/src/mesa/drivers/dri/i965/brw_bufmgr.c
@@ -1252,23 +1252,6 @@ brw_bufmgr_enable_reuse(struct brw_bufmgr *bufmgr)
    bufmgr->bo_reuse = true;
 }
 
-/*
- * Disable buffer reuse for objects which are shared with the kernel
- * as scanout buffers
- */
-int
-brw_bo_disable_reuse(struct brw_bo *bo)
-{
-   bo->reusable = false;
-   return 0;
-}
-
-int
-brw_bo_is_reusable(struct brw_bo *bo)
-{
-   return bo->reusable;
-}
-
 static void
 add_bucket(struct brw_bufmgr *bufmgr, int size)
 {
diff --git a/src/mesa/drivers/dri/i965/brw_bufmgr.h b/src/mesa/drivers/dri/i965/brw_bufmgr.h
index 170909d0ba2..1d3404c3bf2 100644
--- a/src/mesa/drivers/dri/i965/brw_bufmgr.h
+++ b/src/mesa/drivers/dri/i965/brw_bufmgr.h
@@ -246,22 +246,6 @@ int brw_bo_busy(struct brw_bo *bo);
  */
 int brw_bo_madvise(struct brw_bo *bo, int madv);
 
-/**
- * Disable buffer reuse for buffers which will be shared in some way,
- * as with scanout buffers. When the buffer reference count goes to
- * zero, it will be freed and not placed in the reuse list.
- *
- * \param bo Buffer to disable reuse for
- */
-int brw_bo_disable_reuse(struct brw_bo *bo);
-
-/**
- * Query whether a buffer is reusable.
- *
- * \param bo Buffer to query
- */
-int brw_bo_is_reusable(struct brw_bo *bo);
-
 /* drm_bacon_bufmgr_gem.c */
 struct brw_bufmgr *brw_bufmgr_init(struct gen_device_info *devinfo,
                                    int fd, int batch_size);
-- 
2.12.1



More information about the mesa-dev mailing list