[Mesa-dev] [PATCH 6/8] i965/drm: Make brw_bo_alloc_tiled flags parameter 32-bit.

[Chris Wilson]

On Tue, Apr 11, 2017 at 09:02:49AM -0700, Kenneth Graunke wrote:
> unsigned long is a terrible type for a bitfield - if you need fewer
> than 32 bits, it wastes 4 bytes.  If you need more, things break on
> 32-bit builds.  Just use unsigned.
> 
> Even that's a bit ridiculous as we only have one flag today.
> Still, it's at least somewhat better.

Are we talking about packing? You could fit the tiling mode and a few
more flags into the unused 6 bits of uint32_t stride ;) I'll get my coat.

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre