[Mesa-dev] [PATCH v2 11/15] llvmpipe: remove unused subpixel_snap() and fixed_to_float()

Roland Scheidegger sroland at vmware.com
Tue Apr 11 21:01:33 UTC 2017


Reviewed-by: Roland Scheidegger <sroland at vmware.com>

Am 11.04.2017 um 21:59 schrieb Samuel Pitoiset:
> Fixes the following Clang warnings.
> 
> lp_setup_tri.c:55:1: warning: unused function 'subpixel_snap' [-Wunused-function]
> subpixel_snap(float a)
> ^
> lp_setup_tri.c:61:1: warning: unused function 'fixed_to_float' [-Wunused-function]
> fixed_to_float(int a)
> ^
> 
> v2: - do not remove subpixel_snap() (use !PIPE_ARCH_SSE instead)
> 
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/llvmpipe/lp_setup_tri.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/src/gallium/drivers/llvmpipe/lp_setup_tri.c b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
> index 98243a12de..a7a5d05c32 100644
> --- a/src/gallium/drivers/llvmpipe/lp_setup_tri.c
> +++ b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
> @@ -51,18 +51,15 @@
>  #include "util/u_pwr8.h"
>  #endif
>  
> +#if !defined(PIPE_ARCH_SSE)
> +
>  static inline int
>  subpixel_snap(float a)
>  {
>     return util_iround(FIXED_ONE * a);
>  }
>  
> -static inline float
> -fixed_to_float(int a)
> -{
> -   return a * (1.0f / FIXED_ONE);
> -}
> -
> +#endif
>  
>  /* Position and area in fixed point coordinates */
>  struct fixed_position {
> 



More information about the mesa-dev mailing list