[Mesa-dev] [PATCH 15/15] i965: add missing ir_unop_*/ir_binop_* in visit_leave()

Timothy Arceri tarceri at itsqueeze.com
Tue Apr 11 23:33:19 UTC 2017


Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 12/04/17 03:58, Samuel Pitoiset wrote:
> Fixes the following Clang warnings.
>
> brw_fs_channel_expressions.cpp:219:12: warning: enumeration values 'ir_unop_ballot', 'ir_unop_read_first_invocation', and 'ir_binop_read_invocation' not handled in switch [-Wswitch]
>    switch (expr->operation) {
>            ^
> 1 warning generated.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp b/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp
> index 76dbc06535..58fa207880 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp
> @@ -470,6 +470,9 @@ ir_channel_expressions_visitor::visit_leave(ir_assignment *ir)
>     case ir_unop_vote_eq:
>     case ir_unop_unpack_int_2x32:
>     case ir_unop_unpack_uint_2x32:
> +   case ir_unop_ballot:
> +   case ir_unop_read_first_invocation:
> +   case ir_binop_read_invocation:
>        unreachable("unsupported");
>     }
>
>


More information about the mesa-dev mailing list