[Mesa-dev] [PATCH v2 14/18] anv/cmd_buffer: Use the device allocator for QueueSubmit

Chad Versace chadversary at chromium.org
Wed Apr 12 23:05:21 UTC 2017


On Mon 13 Mar 2017, Jason Ekstrand wrote:
> The command is really operating on a Queue not a command buffer and the
> nearest object to that with an allocator is VkDevice.
> 
> Cc: "17.0" <mesa-dev at lists.freedesktop.org>
> ---
>  src/intel/vulkan/anv_batch_chain.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/intel/vulkan/anv_batch_chain.c b/src/intel/vulkan/anv_batch_chain.c
> index 3f6039e..e5cc21d 100644
> --- a/src/intel/vulkan/anv_batch_chain.c
> +++ b/src/intel/vulkan/anv_batch_chain.c
> @@ -1237,7 +1237,7 @@ anv_cmd_buffer_execbuf(struct anv_device *device,
>     adjust_relocations_from_state_pool(ss_pool, &cmd_buffer->surface_relocs,
>                                        cmd_buffer->last_ss_pool_center);
>     anv_execbuf_add_bo(&execbuf, &ss_pool->bo, &cmd_buffer->surface_relocs,
> -                      &cmd_buffer->pool->alloc);
> +                      &device->alloc);

Yep. vkQueueSubmit allows the submitted command buffers to come from
different pools.

The fix looks good.
Reviewed-by: Chad Versace <chadversary at chromium.org>

[...]


More information about the mesa-dev mailing list