[Mesa-dev] [PATCH] swr: return true for PIPE_CAP_DOUBLES

Nicolai Hähnle nhaehnle at gmail.com
Thu Apr 13 15:16:06 UTC 2017


On 13.04.2017 14:20, Rowley, Timothy O wrote:
>
>> On Apr 13, 2017, at 4:26 AM, Nicolai Hähnle <nhaehnle at gmail.com
>> <mailto:nhaehnle at gmail.com>> wrote:
>>
>> On 11.04.2017 18:53, Tim Rowley wrote:
>>> ---
>>> src/gallium/drivers/swr/swr_screen.cpp | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/gallium/drivers/swr/swr_screen.cpp
>>> b/src/gallium/drivers/swr/swr_screen.cpp
>>> index d737ddf..3d3d103 100644
>>> --- a/src/gallium/drivers/swr/swr_screen.cpp
>>> +++ b/src/gallium/drivers/swr/swr_screen.cpp
>>> @@ -248,6 +248,7 @@ swr_get_param(struct pipe_screen *screen, enum
>>> pipe_cap param)
>>>    case PIPE_CAP_TEXTURE_HALF_FLOAT_LINEAR:
>>>    case PIPE_CAP_CULL_DISTANCE:
>>>    case PIPE_CAP_CUBE_MAP_ARRAY:
>>> +   case PIPE_CAP_DOUBLES:
>>>       return 1;
>>>
>>>       /* unsupported features */
>>>
>>
>> You probably also want to update features.txt and the relnotes?
>>
>
> I don’t think so; we always returned the llvmpipe enablement of this
> feature, so the value hasn’t changed.  When the cap moved from being a
> shader cap to a screen cap, we missed adding it to swr.

Oh, alright then, thanks for the clarification.

Cheers,
Nicolai

> -Tim
>
>> Cheers,
>> Nicolai
>> --
>> Lerne, wie die Welt wirklich ist,
>> Aber vergiss niemals, wie sie sein sollte.
>


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.


More information about the mesa-dev mailing list