[Mesa-dev] [PATCH 13/14] mesa/vbo: add KHR_no_error support to DrawElements*() functions

[Timothy Arceri]

On 13/04/17 19:58, Nicolai Hähnle wrote:
> On 13.04.2017 01:42, Timothy Arceri wrote:
>> ---
>>  src/mesa/vbo/vbo_exec_array.c | 158
>> +++++++++++++++++++++++++++---------------
>>  1 file changed, 104 insertions(+), 54 deletions(-)
>>
>> diff --git a/src/mesa/vbo/vbo_exec_array.c
>> b/src/mesa/vbo/vbo_exec_array.c
>> index 6e3cd5a..d85c7ad 100644
>> --- a/src/mesa/vbo/vbo_exec_array.c
>> +++ b/src/mesa/vbo/vbo_exec_array.c
>> @@ -979,129 +979,165 @@ vbo_exec_DrawRangeElements(GLenum mode, GLuint
>> start, GLuint end,
>>
>>  /**
>>   * Called by glDrawElements() in immediate mode.
>>   */
>>  static void GLAPIENTRY
>>  vbo_exec_DrawElements(GLenum mode, GLsizei count, GLenum type,
>>                        const GLvoid * indices)
>>  {
>>     GET_CURRENT_CONTEXT(ctx);
>>
>> -   if (MESA_VERBOSE & VERBOSE_DRAW)
>> -      _mesa_debug(ctx, "glDrawElements(%s, %u, %s, %p)\n",
>> -                  _mesa_enum_to_string(mode), count,
>> -                  _mesa_enum_to_string(type), indices);
>
> MESA_VERBOSE is #define'd to 0 in non-debug builds, so I think you
> should not move this debug print (applies elsewhere as well).

Yeah I noticed that only after making these changes. Will move it back.

>
> Cheers,
> Nicolai
>
>