[Mesa-dev] [PATCH 3/3] winsys/amdgpu: init buffer_indices_hashlist with memset()

Marek Olšák maraeo at gmail.com
Fri Apr 14 19:45:09 UTC 2017


For the series:

Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Fri, Apr 14, 2017 at 6:32 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/winsys/amdgpu/drm/amdgpu_cs.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
> index f068d8ea7a..8a277d08e1 100644
> --- a/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
> +++ b/src/gallium/winsys/amdgpu/drm/amdgpu_cs.c
> @@ -695,8 +695,6 @@ static void amdgpu_ib_finalize(struct amdgpu_ib *ib)
>  static bool amdgpu_init_cs_context(struct amdgpu_cs_context *cs,
>                                     enum ring_type ring_type)
>  {
> -   int i;
> -
>     switch (ring_type) {
>     case RING_DMA:
>        cs->request.ip_type = AMDGPU_HW_IP_DMA;
> @@ -720,9 +718,7 @@ static bool amdgpu_init_cs_context(struct amdgpu_cs_context *cs,
>        break;
>     }
>
> -   for (i = 0; i < ARRAY_SIZE(cs->buffer_indices_hashlist); i++) {
> -      cs->buffer_indices_hashlist[i] = -1;
> -   }
> +   memset(cs->buffer_indices_hashlist, -1, sizeof(cs->buffer_indices_hashlist));
>     cs->last_added_bo = NULL;
>
>     cs->request.number_of_ibs = 1;
> @@ -757,9 +753,7 @@ static void amdgpu_cs_context_cleanup(struct amdgpu_cs_context *cs)
>     cs->num_sparse_buffers = 0;
>     amdgpu_fence_reference(&cs->fence, NULL);
>
> -   for (i = 0; i < ARRAY_SIZE(cs->buffer_indices_hashlist); i++) {
> -      cs->buffer_indices_hashlist[i] = -1;
> -   }
> +   memset(cs->buffer_indices_hashlist, -1, sizeof(cs->buffer_indices_hashlist));
>     cs->last_added_bo = NULL;
>  }
>
> --
> 2.12.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list