[Mesa-dev] [PATCH v2 2/3] etnaviv: Update includes from rnndb

Wladimir J. van der Laan laanwj at gmail.com
Sat Apr 15 05:59:37 UTC 2017


On Sat, Apr 15, 2017 at 07:49:53AM +0200, Wladimir J. van der Laan wrote:
> On Fri, Apr 14, 2017 at 11:57:21PM +0200, Christian Gmeiner wrote:
> > > +#define INST_OPCODE_IMADLOSAT0                                 0x0000004e
> > > +#define INST_OPCODE_IMADLOSAT0                                 0x0000004f
> > 
> > INST_OPCODE_IMADLOSAT0 got redefined...
> 
> Second one should be IMADLOSAT1. Strange, I fixed this but apparently it didn't make it to the patch,
> messed up with git again :(
> https://github.com/etnaviv/etna_viv/blob/master/src/etnaviv/isa.xml.h#L119

I now understand what went wrong: apparently I fixed another instance (IMUL not
IMAD) but not this one.
Strange, hadn't seen a warning for this.
Thanks for the fix,

Regards,
Wladimir


More information about the mesa-dev mailing list