[Mesa-dev] [PATCH 07/12] i965/cnl: Restore lossless compression for sRGB formats

Jason Ekstrand jason at jlekstrand.net
Sun Apr 16 01:27:33 UTC 2017


On April 14, 2017 5:37:55 PM Anuj Phogat <anuj.phogat at gmail.com> wrote:

> From: Ben Widawsky <ben at bwidawsk.net>
>
> This support was removed on gen9 (it worked before then) and was brought back
> for gen10.
>
> Signed-off-by: Ben Widawsky <benjamin.widawsky at intel.com>
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c 
> b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index 467ada5..c8014b9 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -207,7 +207,7 @@ intel_miptree_supports_non_msrt_fast_clear(struct 
> brw_context *brw,
>     if (!brw->format_supported_as_render_target[mt->format])
>        return false;
>
> -   if (brw->gen >= 9) {
> +   if (brw->gen == 9) {
>        mesa_format linear_format = _mesa_get_srgb_format_linear(mt->format);
>        const uint32_t brw_format = brw_isl_format_for_mesa_format(linear_format);
>        return isl_format_supports_ccs_e(&brw->screen->devinfo, brw_format);

I thought sRGB was supported for CCS_E on CNL.  If so, we should update the 
table in isl_format_supports_ccs_e().  Also, I believe sRGB is supported 
for CCS_D even on sky lake, you just can't sample from it.

> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev




More information about the mesa-dev mailing list