[Mesa-dev] [PATCH 3/3] st/mesa: enable ARB_parallel_shader_compile

[Edward O'Callaghan]

On 04/18/2017 09:01 PM, Nicolai Hähnle wrote:
> On 17.04.2017 14:07, Edward O'Callaghan wrote:
>> Signed-off-by: Edward O'Callaghan <funfunctor at folklore1984.net>
>> ---
>>  docs/features.txt                      | 2 +-
>>  src/mesa/state_tracker/st_extensions.c | 1 +
>>  2 files changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/docs/features.txt b/docs/features.txt
>> index 5f63632..4021fbc 100644
>> --- a/docs/features.txt
>> +++ b/docs/features.txt
>> @@ -285,7 +285,7 @@ Khronos, ARB, and OES extensions that are not part
>> of any OpenGL or OpenGL ES ve
>>    GL_ARB_gl_spirv                                       not started
>>    GL_ARB_gpu_shader_int64                               DONE
>> (i965/gen8+, nvc0, radeonsi, softpipe, llvmpipe)
>>    GL_ARB_indirect_parameters                            DONE (nvc0,
>> radeonsi)
>> -  GL_ARB_parallel_shader_compile                        not started,
>> but Chia-I Wu did some related work in 2014
>> +  GL_ARB_parallel_shader_compile                        DONE (radeonsi)
>>    GL_ARB_pipeline_statistics_query                      DONE (i965,
>> nvc0, radeonsi, softpipe, swr)
>>    GL_ARB_post_depth_coverage                            DONE (i965)
>>    GL_ARB_robustness_isolation                           not started
>> diff --git a/src/mesa/state_tracker/st_extensions.c
>> b/src/mesa/state_tracker/st_extensions.c
>> index 61391f8..87fb1e1 100644
>> --- a/src/mesa/state_tracker/st_extensions.c
>> +++ b/src/mesa/state_tracker/st_extensions.c
>> @@ -900,6 +900,7 @@ void st_init_extensions(struct pipe_screen *screen,
>>
>>     /* GL_ARB_parallel_shader_compile */
>>     consts->MaxShaderCompilerThreads = util_cpu_caps.nr_cpus > 1 ?
>> util_cpu_caps.nr_cpus : 0;
>> +   extensions->ARB_parallel_shader_compile = consts->GLSLVersion >=
>> 450 ? GL_TRUE : GL_FALSE;
> 
> Why would you make this depend on the GLSL version?

Technically I suppose it could work regardless however I was just
following the spec to the letter.

> 
> Cheers,
> Nicolai
> 
>>
>>     /* This extension needs full OpenGL 3.2, but we don't know if that's
>>      * supported at this point. Only check the GLSL version. */
>>
> 
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170418/a9a3d6af/attachment.sig>