[Mesa-dev] [RFC 1/2] Revert "mapi: rewrite u_current_init() function without u_thread_self()"

[Emil Velikov]

On 19 April 2017 at 08:45, Timothy Arceri <tarceri at itsqueeze.com> wrote:
> This reverts commit 458c7490c29ef2960a33a089f65490e044da5d27.
>
> The commit did not revert cleanly so this was fixed up by hand.
>
> u_thread_self() will be used by the following patch.
I see your interesting in dropping the legacy/unused extension with
2/2 but this commit is bonkers :-(


> -   else if (!thread_id_equal(knownID, get_thread_id())) {
> +   else if (knownID != u_thread_self()) {
NACK. Direct comparison as seen here is broken and if it works that's
only by coincidence.

I'll just and finish the threading related rework/fixes that I've got
laying around. Please take a look - they should be out by end of
today.

Thanks
Emil