[Mesa-dev] [PATCH 4/4] HACK: st/clover: automake: set -fpermissive for clover/llvm

[Emil Velikov]

On 18 April 2017 at 20:26, Francisco Jerez <currojerez at riseup.net> wrote:
> Emil Velikov <emil.l.velikov at gmail.com> writes:
>
>> Without it the compiler will barf at us with dozens of errors like
>> the following.
>>
>> In file included from llvm/codegen/bitcode.cpp:34:0:
>> ./llvm/codegen.hpp:52:22: error: ‘<::’ cannot begin a template-argument list [-fpermissive]
>> ./llvm/codegen.hpp:52:22: note: ‘<:’ is an alternate spelling for ‘[’. Insert whitespace between ‘<’ and ‘::’
>> ./llvm/codegen.hpp:52:22: note: (if you use ‘-fpermissive’ G++ will accept your code)
>>
>> Note: things seems to build fine on my system, although the Travis-CI
>> instance [1] is less forgiving. I'm not too happy on the patch hence the
>> HACK - suggestions are greatly appreciated.
>>
>> Cc: Francisco Jerez <currojerez at riseup.net>
>> Cc: Jan Vesely <jan.vesely at rutgers.edu>
>> Cc: Aaron Watry <awatry at gmail.com>
>> [1] https://travis-ci.org/evelikov/Mesa/jobs/223222840
>> ---
>>  src/gallium/state_trackers/clover/Makefile.am | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/gallium/state_trackers/clover/Makefile.am b/src/gallium/state_trackers/clover/Makefile.am
>> index 321393536dc..c39a3c065d7 100644
>> --- a/src/gallium/state_trackers/clover/Makefile.am
>> +++ b/src/gallium/state_trackers/clover/Makefile.am
>> @@ -39,6 +39,7 @@ libcltgsi_la_SOURCES = $(TGSI_SOURCES)
>>
>>  libclllvm_la_CXXFLAGS = \
>>       -std=c++11 \
>> +     -fpermissive \
>
> -fpermissive is quite a big hammer...  How about we add a space between
> the '<' and '::' instead as the error message suggests?
>
Right - got confused by the message :-)
That works like a charm. Will send a patch in a second.

-Emil