[Mesa-dev] [PATCH] mesa/glthread: correctly comparae thread handles

[Brian Paul]

In the subject line "compare"

Reviewed-by: Brian Paul <brianp at vmware.com>


On 04/20/2017 09:24 AM, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> As mentioned in the manual - comparing pthread_t handles via the C
> comparison operator is incorrect and pthread_equal() should be used
> instead.
>
> Cc: Timothy Arceri <tarceri at itsqueeze.com>
> Cc: Eric Anholt <eric at anholt.net>
> Fixes: d8d81fbc316 ("mesa: Add infrastructure for a worker thread to process GL commands.")
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>   src/mesa/main/glthread.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/mesa/main/glthread.c b/src/mesa/main/glthread.c
> index c4d3f4a4349..455b829cd8d 100644
> --- a/src/mesa/main/glthread.c
> +++ b/src/mesa/main/glthread.c
> @@ -265,7 +265,7 @@ _mesa_glthread_finish(struct gl_context *ctx)
>       * dri interface entrypoints), in which case we don't need to actually
>       * synchronize against ourself.
>       */
> -   if (pthread_self() == glthread->thread)
> +   if (pthread_equal(pthread_self(), glthread->thread))
>         return;
>
>      pthread_mutex_lock(&glthread->mutex);
>