[Mesa-dev] [PATCH] st/mesa/i965: validate sampler type across the whole program

Timothy Arceri tarceri at itsqueeze.com
Fri Apr 21 07:09:04 UTC 2017


On 21/04/17 16:02, Tapani Pälli wrote:
> 
> 
> On 04/19/2017 05:15 AM, Timothy Arceri wrote:
>> Hi Tapani,
>>
>> You seem to have been one of the last people to touch this code. Do 
>> you think you could take a look at this patch?
> 
> OK sure.
> 
> The validation loop looks fine to me but I find it strange that we need 
> to initialize SamplersValidated on each LinkShader hook separately, 
> could we just do it once, perhaps _mesa_clear_shader_program_data() or 
> such that gets called when starting to link?

Good point. I've sent a V2 thanks.

> 
> 
>> Thanks,
>> Tim
>>


More information about the mesa-dev mailing list