[Mesa-dev] [PATCH 00/11] some GLSL cleanups

Edward O'Callaghan funfunctor at folklore1984.net
Fri Apr 21 11:20:23 UTC 2017


Series is,

Reviewed-by: Edward O'Callaghan <funfunctor at folklore1984.net>

On 04/21/2017 08:44 PM, Samuel Iglesias Gonsálvez wrote:
> Series is,
> 
> Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> 
> Sam
> 
> On Fri, 2017-04-21 at 11:53 +0200, Samuel Pitoiset wrote:
>> The glsl_type helpers interface is quite nice and this (trivial)
>> series tends to make use of the is_XXX() functions everywhere it's
>> possible.
>>
>> Please review,
>> Thanks!
>>
>> Samuel Pitoiset (11):
>>   glsl: add glsl_type::is_atomic_uint() helper
>>   glsl: make use glsl_type::is_atomic_uint()
>>   glsl: make use of glsl_type::is_array()
>>   glsl: make use of glsl_type::is_interface()
>>   glsl: make use of glsl_type::is_record()
>>   glsl: make use of glsl_type::is_boolean()
>>   glsl: add glsl_type::is_integer_64()
>>   glsl: simplify glsl_type::is_integer_32_64()
>>   glsl: make use of glsl_type::is_integer_64()
>>   glsl: make use of glsl_type::is_double()
>>   glsl: make use of glsl_type::is_float()
>>
>>  src/compiler/glsl/ast_function.cpp                 |   5 +-
>>  src/compiler/glsl/ast_to_hir.cpp                   |  18 ++-
>>  src/compiler/glsl/builtin_functions.cpp            |  12 +-
>>  src/compiler/glsl/glsl_to_nir.cpp                  |   4 +-
>>  src/compiler/glsl/hir_field_selection.cpp          |   3 +-
>>  src/compiler/glsl/ir.cpp                           |   9 +-
>>  src/compiler/glsl/ir_equals.cpp                    |   2 +-
>>  src/compiler/glsl/ir_expression_operation.py       |  11 +-
>>  src/compiler/glsl/ir_function.cpp                  |   6 +-
>>  src/compiler/glsl/ir_print_visitor.cpp             |   5 +-
>>  src/compiler/glsl/ir_reader.cpp                    |   2 +-
>>  src/compiler/glsl/ir_validate.cpp                  | 130 ++++++++++-
>> ----------
>>  src/compiler/glsl/link_uniforms.cpp                |   2 +-
>>  src/compiler/glsl/link_varyings.cpp                |   2 +-
>>  src/compiler/glsl/linker.cpp                       |   3 +-
>>  src/compiler/glsl/lower_buffer_access.cpp          |   6 +-
>>  src/compiler/glsl/lower_int64.cpp                  |  11 +-
>>  src/compiler/glsl/opt_algebraic.cpp                |   9 +-
>>  src/compiler/glsl/shader_cache.cpp                 |   2 +-
>>  .../glsl/tests/uniform_initializer_utils.cpp       |   2 +-
>>  src/compiler/glsl_types.h                          |  21 +++-
>>  src/mesa/program/ir_to_mesa.cpp                    |   4 +-
>>  src/mesa/state_tracker/st_glsl_to_tgsi.cpp         |  10 +-
>>  23 files changed, 137 insertions(+), 142 deletions(-)
>>
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/mesa-dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170421/c1cfe1d9/attachment.sig>


More information about the mesa-dev mailing list