[Mesa-dev] [PATCH 2/5] trace: don't trace resource_destroy

[Nicolai Hähnle]

On 23.04.2017 01:10, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> due to the lack of pipe_resource wrapping, we can get this call from inside
> of driver calls, which would try to lock an already-locked mutex.
> ---
>  src/gallium/drivers/trace/tr_screen.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/src/gallium/drivers/trace/tr_screen.c b/src/gallium/drivers/trace/tr_screen.c
> index 0fa8d0f..3142386 100644
> --- a/src/gallium/drivers/trace/tr_screen.c
> +++ b/src/gallium/drivers/trace/tr_screen.c
> @@ -384,27 +384,20 @@ trace_screen_resource_changed(struct pipe_screen *_screen,
>     trace_dump_call_end();
>  }
>
>  static void
>  trace_screen_resource_destroy(struct pipe_screen *_screen,
>  			      struct pipe_resource *resource)
>  {
>     struct trace_screen *tr_scr = trace_screen(_screen);
>     struct pipe_screen *screen = tr_scr->screen;
>
> -   trace_dump_call_begin("pipe_screen", "resource_destroy");
> -
> -   trace_dump_arg(ptr, screen);
> -   trace_dump_arg(ptr, resource);
> -
> -   trace_dump_call_end();
> -

Please add a short comment here, otherwise someone might re-add the 
tracing without considering the issue.

Cheers,
Nicolai

>     screen->resource_destroy(screen, resource);
>  }
>
>
>  /********************************************************************
>   * fence
>   */
>
>
>  static void
>


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.