[Mesa-dev] [PATCH] autogen.sh: set default sendemail.to

[Dylan Baker]

I agree with Jason, autogen.sh shouldn't be doing anything except configuring
autotools. Perhaps a "initial-configuration.sh" script would be more
appropriate.

Just my two cents and not a hard NAK.

Dylan

Quoting Jason Ekstrand (2017-04-24 12:29:32)
> This seems like something that would be more appropriate to put on a 
> "getting started" page than autogen.sh.  The very last thing I (as a user 
> of it) would expect autogen.sh to do is monkey with my git config; local or 
> otherwise.
> 
> 
> On April 24, 2017 6:16:14 PM Emil Velikov <emil.l.velikov at gmail.com> wrote:
> 
> > From: Emil Velikov <emil.velikov at collabora.com>
> >
> > To ease patch submission process a tiny bit.
> >
> > Cc: Ben Widawsky <ben at bwidawsk.net>
> > Suggested-by: Ben Widawsky <ben at bwidawsk.net>
> > Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> > ---
> >  autogen.sh | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/autogen.sh b/autogen.sh
> > index c8960971d24..d178880b407 100755
> > --- a/autogen.sh
> > +++ b/autogen.sh
> > @@ -6,6 +6,9 @@ test -z "$srcdir" && srcdir=.
> >  ORIGDIR=`pwd`
> >  cd "$srcdir"
> >
> > +git config --local --get sendemail.to >/dev/null ||
> > +    git config --local sendemail.to "mesa-dev at lists.freedesktop.org" 
> > 2>/dev/null
> > +
> >  autoreconf --force --verbose --install || exit 1
> >  cd "$ORIGDIR" || exit $?
> >
> > --
> > 2.12.2
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
> 
> 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: signature
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170424/4816c9d4/attachment.sig>