[Mesa-dev] [PATCH 3/3] r600g: remove unused sbcl env. variable

Constantine Kharlamov Hi-Angel at yandex.ru
Tue Apr 25 03:48:26 UTC 2017


Thank you, and congratulations on the new card :)

On 25.04.2017 04:26, Dieter Nützel wrote:
> For the series:
> 
> Tested-by: Dieter Nützel <Dieter at nuetzel-hh.de>
> 
> On Turks XT (6670).
> 
> radeonsi (2/3) NOT yet (only compile),
> my RX 580, 8 GB, Nitro+
> is coming on Friday/Saturday, Yeahhhh ;-)
> 
> Dieter
> 
> Am 23.04.2017 23:36, schrieb Constantine Kharlamov:
>> sb-based optimization was only used for older LLVM, whose support was removed
>> in 100796c15c3a1467d03abc424e6f1494da02f376 "gallium/radeon: drop support for
>> LLVM 3.5". Since then sbcl variable doesn't do anything.
>>
>> Signed-off-by: Constantine Kharlamov <Hi-Angel at yandex.ru>
>> ---
>>  src/gallium/drivers/r600/r600_pipe.c       | 1 -
>>  src/gallium/drivers/r600/sb/notes.markdown | 1 -
>>  2 files changed, 2 deletions(-)
>>
>> diff --git a/src/gallium/drivers/r600/r600_pipe.c
>> b/src/gallium/drivers/r600/r600_pipe.c
>> index 12bf5517a9..a7b28a2d57 100644
>> --- a/src/gallium/drivers/r600/r600_pipe.c
>> +++ b/src/gallium/drivers/r600/r600_pipe.c
>> @@ -47,7 +47,6 @@ static const struct debug_named_value r600_debug_options[] = {
>>
>>      /* shader backend */
>>      { "nosb", DBG_NO_SB, "Disable sb backend for graphics shaders" },
>> -    { "sbcl", DBG_SB_CS, "Enable sb backend for compute shaders" },
>>      { "sbdry", DBG_SB_DRY_RUN, "Don't use optimized bytecode (just print
>> the dumps)" },
>>      { "sbstat", DBG_SB_STAT, "Print optimization statistics for shaders" },
>>      { "sbdump", DBG_SB_DUMP, "Print IR dumps after some optimization passes" },
>> diff --git a/src/gallium/drivers/r600/sb/notes.markdown
>> b/src/gallium/drivers/r600/sb/notes.markdown
>> index 63c010883d..e48135c69c 100644
>> --- a/src/gallium/drivers/r600/sb/notes.markdown
>> +++ b/src/gallium/drivers/r600/sb/notes.markdown
>> @@ -13,7 +13,6 @@ Debugging
>>      There are new flags:
>>
>>      -   **nosb** - Disable sb backend for graphics shaders
>> -    -   **sbcl** - Enable optimization of compute shaders (experimental)
>>      -   **sbdry** - Dry run, optimize but use source bytecode -
>>          useful if you only want to check shader dumps
>>          without the risk of lockups and other problems


More information about the mesa-dev mailing list