[Mesa-dev] [PATCH] autogen.sh: set default sendemail.to

Eric Engestrom eric.engestrom at imgtec.com
Tue Apr 25 12:33:38 UTC 2017


On Tuesday, 2017-04-25 12:10:46 +0100, Emil Velikov wrote:
> On 24 April 2017 at 20:29, Jason Ekstrand <jason at jlekstrand.net> wrote:
> > This seems like something that would be more appropriate to put on a
> > "getting started" page than autogen.sh.  The very last thing I (as a user of
> > it) would expect autogen.sh to do is monkey with my git config; local or
> > otherwise.
> >
> Close to nobody reads the documentation, esp. with the current website design.
> 
> I agree that it's not pretty, yet only the local sendemail.to is set
> and only if it's not set already.
> Thus nothing should change for you and dozens of other developers.
> 
> X and a handful of other projects use autogen.sh/bootstrap to do this
> kind of setup. Some even add git hooks so that trivial things such as
> coding style is checked automatically.

Agreed, if only for consistency, this should do what the others do.
A separate script might be more appropriate, but most drive-by devs
won't run it, and regular devs already have this set so it's a no-op
anyway.

Acked-by: Eric Engestrom <eric.engestrom at imgtec.com>

> 
> -Emil


More information about the mesa-dev mailing list