[Mesa-dev] [Mesa-stable] [PATCH] i965/vec4: Use reads_accumulator_implicitly(), not MACH checks.

[Kenneth Graunke]

On Tuesday, April 25, 2017 5:24:09 AM PDT Andres Gomez wrote:
> On Tue, 2017-04-25 at 11:57 +0200, Juan A. Suarez Romero wrote:
> > On Sat, 2017-04-22 at 16:28 -0700, Kenneth Graunke wrote:
> > > Curro pointed out that I should not just check for MACH, but use
> > > the reads_accumulator_implicitly() helper, which would also prevent
> > > the same bug with MAC and SADA2 (if we ever decide to use them).
> > > 
> > 
> > This seems to rely on commit 2faf227ec2e (i965/vec4: Avoid reswizzling
> > MACH instructions in opt_register_coalesce()), which is not available
> > in stable.
> > 
> > But taking a look at it, I think it could be good candidate to be also
> > in stable.
> > 
> > 
> > WDYT? Can we propose 2faf227ec2e to stable?
> 
> ...
> 
> > > Emil - you'll need to cherry-pick 9347acac440190af67fce7b5f28e8eee7245fb6d
> > > before picking this patch.  I forgot to nominate it for stable, sorry!
> 
> Kenneth already proposed to do so, he just didn't provide the proper
> commit id, which is 2faf227ec2e, as you identified correctly.
> 
> Let's do so!

Yeah, definitely - I just forgot to mark it before pushing.  Sorry!

--Ken
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170425/effc643c/attachment-0001.sig>