[Mesa-dev] [PATCH 7/7] st/glsl_to_tgsi: make undef_src and undef_dst const

Timothy Arceri tarceri at itsqueeze.com
Wed Apr 26 01:22:09 UTC 2017


I'm not overly familiar with some of the code in 2-4 but it seems to 
make sense so for what its worth. For the series:

Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 19/04/17 18:56, Nicolai Hähnle wrote:
> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
> 
> ---
>   src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> index c0f8d7c..5026dce 100644
> --- a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> +++ b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp
> @@ -339,22 +339,22 @@ public:
>         this->size32 = size32;
>         this->type = type;
>      }
>   
>      /* doubles are stored across 2 gl_constant_values */
>      gl_constant_value values[4];
>      int size32; /**< Number of 32-bit components (1-4) */
>      int type; /**< GL_DOUBLE, GL_FLOAT, GL_INT, GL_BOOL, or GL_UNSIGNED_INT */
>   };
>   
> -static st_src_reg undef_src = st_src_reg(PROGRAM_UNDEFINED, 0, GLSL_TYPE_ERROR);
> -static st_dst_reg undef_dst = st_dst_reg(PROGRAM_UNDEFINED, SWIZZLE_NOOP, GLSL_TYPE_ERROR);
> +static const st_src_reg undef_src = st_src_reg(PROGRAM_UNDEFINED, 0, GLSL_TYPE_ERROR);
> +static const st_dst_reg undef_dst = st_dst_reg(PROGRAM_UNDEFINED, SWIZZLE_NOOP, GLSL_TYPE_ERROR);
>   
>   struct inout_decl {
>      unsigned mesa_index;
>      unsigned array_id; /* TGSI ArrayID; 1-based: 0 means not an array */
>      unsigned size;
>      unsigned interp_loc;
>      unsigned gs_out_streams;
>      enum glsl_interp_mode interp;
>      enum glsl_base_type base_type;
>      ubyte usage_mask; /* GLSL-style usage-mask,  i.e. single bit per double */
> 


More information about the mesa-dev mailing list