[Mesa-dev] [PATCH v2 12/31] glsl: allow bindless images to be declared inside structures

Timothy Arceri tarceri at itsqueeze.com
Wed Apr 26 02:45:49 UTC 2017


Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>

On 24/04/17 20:35, Samuel Pitoiset wrote:
> The spec doesn't clearly state this, but I have got clarifiation
> from the spec authors.
> 
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>   src/compiler/glsl/ast_to_hir.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp
> index a63f9da912..5ef99bf504 100644
> --- a/src/compiler/glsl/ast_to_hir.cpp
> +++ b/src/compiler/glsl/ast_to_hir.cpp
> @@ -6944,7 +6944,7 @@ ast_process_struct_or_iface_block_members(exec_list *instructions,
>               _mesa_glsl_error(&loc, state, "atomic counter in structure");
>            }
>   
> -         if (decl_type->contains_image()) {
> +         if (!state->has_bindless() && decl_type->contains_image()) {
>               /* FINISHME: Same problem as with atomic counters.
>                * FINISHME: Request clarification from Khronos and add
>                * FINISHME: spec quotation here.
> 


More information about the mesa-dev mailing list