[Mesa-dev] [RFC 0/1] Port dri2GetBuffersWithFormat/dri2GetBuffers to XCB

Gregory Hainaut gregory.hainaut at gmail.com
Wed Apr 26 08:07:46 UTC 2017


Following the discussion in "[PATCH v4 0/3] asynchronous pbo transfer with glthread"

It will help apps that are ported to XCB. But Xlib (without XInitThread) apps
will still crash when glthread is enabled on DRI2.

I only tested the patch on Nouveau

There are 3 remaining possibilities
* Won't fix. DRI3/XCB is the future
* Enable thread safe Xlib by default (which would make sense in multicore CPU era)
* Track gl call that will use X11 API to force a sync

Note: I don't know if xcb_dri2_get_buffers_buffers can return a NULL
so I added a check in doubt.

Best Regards,

Gregory Hainaut (1):
  glx: port dri2GetBuffers/dri2GetBuffersWithFormat to XCB

 src/glx/dri2.c     | 118 -----------------------------------------------------
 src/glx/dri2.h     |  25 ------------
 src/glx/dri2_glx.c |  64 +++++++++++++++++++++--------
 3 files changed, 47 insertions(+), 160 deletions(-)

-- 
2.11.0



More information about the mesa-dev mailing list