[Mesa-dev] [PATCH] st/glsl_to_tgsi: drop the merge_registers() pass

[Marek Olšák]

On Mon, Apr 24, 2017 at 11:42 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
>
>
> On 04/24/2017 11:22 PM, Rob Clark wrote:
>>
>> On Mon, Apr 24, 2017 at 5:18 PM, Samuel Pitoiset
>> <samuel.pitoiset at gmail.com> wrote:
>>>
>>>
>>>
>>> On 04/24/2017 11:12 PM, Rob Clark wrote:
>>>>
>>>>
>>>> so I guess this is likely to hurt pipe drivers that don't (yet?) have
>>>> a real compiler backend.  (Ie. etnaviv and freedreno/a2xx.)  So maybe
>>>> it should be optional.
>>>
>>>
>>>
>>> I can't say for these drivers, but it seems safer to add an option if
>>> this
>>> can hurt them. How about PIPE_SHADER_CAP_TGSI_MERGE_REGISTERS?
>>
>>
>> so we have already PIPE_CAP_GLSL_OPTIMIZE_CONSERVATIVELY .. not sure
>> why that is a cap and not a shader-cap, tbh.  I guess I'm ok with
>> either bikeshed color ;-)
>
>
> yeah, not sure of the _SHADER_ or not :)

Shader CAPs are mainly used when the value may vary with each shader stage.

Marek