[Mesa-dev] [PATCH] RFC: mesa: remove MESA_VERBOSE env variable

[Emil Velikov]

On 21 April 2017 at 17:46, Jordan Justen <jordan.l.justen at intel.com> wrote:
> On 2017-04-21 04:02:11, Emil Velikov wrote:
>> On 21 April 2017 at 07:18, Jordan Justen <jordan.l.justen at intel.com> wrote:
>> > On 2017-04-20 18:49:57, Timothy Arceri wrote:
>> >> On 21/04/17 11:37, Jordan Justen wrote:
>> >> > On 2017-04-20 12:33:45, Samuel Pitoiset wrote:
>> >> >> I have used it sometimes, but since VERBOSE_API is missing in a bunch of
>> >> >> places, that's quite useless. :)
>> >> >>
>> >> >
>> >> > I also use MESA_VERBOSE=api every few months or so. I've found it
>> >> > pretty useful, but frustratingly I've nearly always ended up having to
>> >> > add new calls for it become useful.
>> >> >
>> >> > Something that automates wrapping the API probably is perhaps more
>> >> > maintainable.
>> >>
>> >> As Eric mentioned it would probably be best to add something to dispatch
>> >> generation if we want this to be reliable. It shouldn't be too difficult
>> >> to do.
>> >>
>> >
>> > Could that version could be implemented as a replacement before
>> > removing the current version?
>> >
>> As you pointed out this is something we might want to have in GLVND.
>> Not sure if how long it will take to write/merge that so stalling on
>> it is a bit... meh.
>>
>
> I guess when removing a feature that you don't use, it is easy to say
> 'meh' about its possible future replacement. I've actually used this
> feature while debugging 2 applications in the past month.
>
Agreed on the "meh" part, it was rather selfish of me.
I think the bigger question that's missing is - what was the obstacle
of using apitrace/similar tool?

> Admittedly, this a bit more than I normally use it, but I also don't
> see a motivation to removing it. So why not stall until there is an
> alternative?
>
Until we yank this out [close to] nobody will bother with an alternative.

As you mentioned it - MESA_VERBOSE becomes useful after spending time fixing it.
Not sure why you'd want to single-handedly maintain this behemoth - oh
well, so be it.

-Emil