[Mesa-dev] [PATCH 2/2] i965: Always set AALINEDISTANCE_TRUE on Sandybridge.

Manolova, Plamena plamena.manolova at intel.com
Wed Apr 26 22:36:34 UTC 2017


Looks good to me :)

This series is: Reviewed-by: Plamena Manolova <plamena.manolova at intel.com>

On Wed, Apr 26, 2017 at 3:15 PM, Kenneth Graunke <kenneth at whitecape.org>
wrote:

> We set this unconditionally on every other platform.  Zero (Manhattan)
> isn't even listed as an option in the Sandybridge docs - only "true".
>
> Cc: rafael.antognolli at intel.com
> ---
>  src/mesa/drivers/dri/i965/gen6_sf_state.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/gen6_sf_state.c
> b/src/mesa/drivers/dri/i965/gen6_sf_state.c
> index dd547790c9a..0f118b6678b 100644
> --- a/src/mesa/drivers/dri/i965/gen6_sf_state.c
> +++ b/src/mesa/drivers/dri/i965/gen6_sf_state.c
> @@ -286,7 +286,7 @@ upload_sf_state(struct brw_context *brw)
>
>     dw1 = GEN6_SF_SWIZZLE_ENABLE | num_outputs <<
> GEN6_SF_NUM_OUTPUTS_SHIFT;
>     dw2 = GEN6_SF_STATISTICS_ENABLE;
> -   dw3 = GEN6_SF_SCISSOR_ENABLE;
> +   dw3 = GEN6_SF_SCISSOR_ENABLE | GEN6_SF_LINE_AA_MODE_TRUE;
>     dw4 = 0;
>
>     if (brw->sf.viewport_transform_enable)
> @@ -365,7 +365,6 @@ upload_sf_state(struct brw_context *brw)
>     }
>     if (ctx->Line.SmoothFlag) {
>        dw3 |= GEN6_SF_LINE_AA_ENABLE;
> -      dw3 |= GEN6_SF_LINE_AA_MODE_TRUE;
>        dw3 |= GEN6_SF_LINE_END_CAP_WIDTH_1_0;
>     }
>     /* _NEW_MULTISAMPLE */
> --
> 2.12.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170426/877193f0/attachment.html>


More information about the mesa-dev mailing list