[Mesa-dev] [PATCH] radv: fix regression in descriptor set freeing.

Bas Nieuwenhuizen bas at basnieuwenhuizen.nl
Thu Apr 27 00:14:05 UTC 2017


Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>

On Thu, Apr 27, 2017 at 1:35 AM, Dave Airlie <airlied at gmail.com> wrote:
> From: Dave Airlie <airlied at redhat.com>
>
> Since the host pool changes,
>
> Fixes:
> dEQP-VK.api.descriptor_pool.out_of_pool_memory
>
> Fixes: 126d5ad "radv: Use host memory pool for non-freeable descriptors."
> Signed-off-by: Dave Airlie <airlied at redhat.com>
> ---
>  src/amd/vulkan/radv_descriptor_set.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c
> index b608063..ec7fd3d 100644
> --- a/src/amd/vulkan/radv_descriptor_set.c
> +++ b/src/amd/vulkan/radv_descriptor_set.c
> @@ -527,7 +527,7 @@ VkResult radv_FreeDescriptorSets(
>         for (uint32_t i = 0; i < count; i++) {
>                 RADV_FROM_HANDLE(radv_descriptor_set, set, pDescriptorSets[i]);
>
> -               if (set)
> +               if (set && !pool->host_memory_base)
>                         radv_descriptor_set_destroy(device, pool, set, true);
>         }
>         return VK_SUCCESS;
> --
> 2.9.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list