[Mesa-dev] [PATCH 1/4] r600g: avoid redundant DB registerupdates

[Constantine Kharlamov]

27.04.2017, 11:32, "Marc Dietrich" <marvin24 at gmx.de>:
> Am Donnerstag, 27. April 2017, 10:05:32 CEST schrieb Marc Dietrich:
>>  Am Mittwoch, 26. April 2017, 19:48:46 CEST schrieb Constantine Kharlamov:
>>  > On 26.04.2017 17:51, Marc Dietrich wrote:
>>  > > Am Mittwoch, 26. April 2017, 16:36:39 CEST schrieb Constantine
>
> Kharlamov:
>>  > >> HEAD recently have triggered a bug in sb compiler, so, just for the
>>  > >> safe
>>  > >> case, can you tell if reverting this commit
>>  > >>
>>  > >> git revert --no-commit eb8aa93c03ee89ffd3041d41b6293e4b282b6ce6
>>  > >>
>>  > >> but having my patch still applied changes anything or not?
>>  > >>
>>  > >> (I have this commit reverted locally)
>>  > >
>>  > > still same crash.
>>  > >
>>  > > Marc
>>  >
>>  > Could you tell what settings you have applied in UH4?
>>  >
>>  > (I'm just hoping to reproduce it locally, but the default ones didn't
>>  > crash
>>  > it)
>>
>>  Custom Preset: Quality: low, everything disabled, Resolution: 640x360: gives
>>  "~ 7 fps".
>>
>>  I have to admit that I saw a similar crash two weeks ago, but nothing since
>>  that time. If you can't find something wrong with your first patch (is it
>>  just some kind of refactoring?), it is possible that your patch just
>>  triggers something which was already there before. Your patch just makes it
>>  reproducible. Just a wild guess though.
>
> just another test point: I applied your first patch (not sure if this makes
> sense) to mesa 17.1.0-rc2 (disabled shader cache and mesa_glthread) and there
> crash still happens.
>
> Marc

Thank you. I've got an idea for what to change, but can't send a patch ATM as I'm not at home, a bit later.