[Mesa-dev] [PATCH 10/12] Android: default to building all drivers

[Rob Herring]

On Thu, Apr 27, 2017 at 9:50 PM, Chih-Wei Huang <cwhuang at android-x86.org> wrote:
> A typo in the subject?
> (s/building/build/)

It's a bit misleading as originally I wrote it such that a blank
BOARD_GPU_DRIVERS would enable all drivers, then changed it to "all".
So it's not really a default anymore.

> 2017-04-28 3:43 GMT+08:00 Rob Herring <robh at kernel.org>:
>> If BOARD_GPU_DRIVERS is empty, build all the drivers. This doesn't
>> enable building mesa as that is controlled by including libGLES_mesa in
>> the product.
>>
>> Signed-off-by: Rob Herring <robh at kernel.org>
>> ---
>>  Android.mk | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/Android.mk b/Android.mk
>> index 9f481ee7e109..76858c1616bc 100644
>> --- a/Android.mk
>> +++ b/Android.mk
>> @@ -1,3 +1,4 @@
>> +
>>  # Mesa 3-D graphics library
>>  #
>>  # Copyright (C) 2010-2011 Chia-I Wu <olvaffe at gmail.com>
>> @@ -53,8 +54,15 @@ gallium_drivers := \
>>         vc4.HAVE_GALLIUM_VC4 \
>>         virgl.HAVE_GALLIUM_VIRGL
>>
>> +$(warning $(BOARD_GPU_DRIVERS))
>> +
>> +ifeq ($(BOARD_GPU_DRIVERS),all)
>> +MESA_BUILD_CLASSIC := $(filter HAVE_%, $(subst ., , $(classic_drivers)))
>> +MESA_BUILD_GALLIUM := $(filter HAVE_%, $(subst ., , $(gallium_drivers)))
>> +else
>>  MESA_BUILD_CLASSIC := $(strip $(foreach d, $(BOARD_GPU_DRIVERS), $(patsubst $(d).%,%, $(filter $(d).%, $(classic_drivers)))))
>>  MESA_BUILD_GALLIUM := $(strip $(foreach d, $(BOARD_GPU_DRIVERS), $(patsubst $(d).%,%, $(filter $(d).%, $(gallium_drivers)))))
>> +endif
>>  $(foreach d, $(MESA_BUILD_CLASSIC) $(MESA_BUILD_GALLIUM), $(eval $(d) := true))
>>
>>  # host and target must be the same arch to generate matypes.h
>> --
>
> Aren't some drivers for arm or x86 only?

In practice, yes. But they should build on all architectures so folks
can easily build test. If the arm only ones required an arm compiler
for example, then none of the x86 folks would build them and check
that their changes don't break any drivers.

> Is it really possible to build all drivers?

Yes. That is what my CI job does.

Rob