[Mesa-dev] [PATCH v02 13/37] i965: Split out enum from brw_eu_defines.h

Kenneth Graunke kenneth at whitecape.org
Fri Apr 28 23:03:46 UTC 2017


On Monday, April 24, 2017 3:19:08 PM PDT Rafael Antognolli wrote:
> We need to use some enums inside genX_state_upload.c, but including the
> whole header will cause several conflicts between things defined in this
> header and the genxml auto-generated headers.
> 
> So create a separate header that is included both by brw_eu_defines.h
> and genX_state_upload.c.
> 
> Signed-off-by: Rafael Antognolli <rafael.antognolli at intel.com>
> ---
>  src/intel/Makefile.sources              |  1 +-
>  src/intel/compiler/brw_defines_common.h | 46 ++++++++++++++++++++++++++-
>  src/intel/compiler/brw_eu_defines.h     | 22 +------------
>  3 files changed, 48 insertions(+), 21 deletions(-)
>  create mode 100644 src/intel/compiler/brw_defines_common.h

I don't really like this, but without digging into the issue, I'm not
sure what else to suggest.

Acked-by: Kenneth Graunke <kenneth at whitecape.org>

Maybe we could just remove the conflicting pieces?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170428/7b21b97a/attachment.sig>


More information about the mesa-dev mailing list