[Mesa-dev] [PATCH] gallium/targets: fix bool setting on BE architectures

Emil Velikov emil.l.velikov at gmail.com
Sat Apr 29 13:18:12 UTC 2017


On 18 April 2017 at 05:00, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> val_bool and val_int are in a union. val_bool gets the first byte, which
> happens to work on LE when setting via the int, but breaks on BE. By
> setting the value properly, we are able to use DRI3 on BE architectures.
> Tested by running glxgears with a NV34 in a G5 PPC.
>
> Signed-off-by: Ilia Mirkin <imirkin at alum.mit.edu>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>  src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 8 ++++----
>  src/gallium/targets/pipe-loader/pipe_i915.c         | 2 +-
>  src/gallium/targets/pipe-loader/pipe_msm.c          | 2 +-
>  src/gallium/targets/pipe-loader/pipe_nouveau.c      | 2 +-
>  src/gallium/targets/pipe-loader/pipe_r300.c         | 2 +-
>  src/gallium/targets/pipe-loader/pipe_r600.c         | 2 +-
>  src/gallium/targets/pipe-loader/pipe_radeonsi.c     | 2 +-
>  7 files changed, 10 insertions(+), 10 deletions(-)
>
A while ago I've managed to half the duplication, but we still have some ;-)

With the vmwgfx hunk squashed:
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

-Emil


More information about the mesa-dev mailing list