[Mesa-dev] [Mesa-stable] [PATCH] nv50/ir: skip optimizing ADD+SHL to SHLADD when src(1) is 0

[Samuel Pitoiset]

On 04/29/2017 06:14 PM, Emil Velikov wrote:
> Hi Samuel,
> 
> On 29 April 2017 at 17:01, Samuel Pitoiset <samuel.pitoiset at gmail.com> wrote:
>> Doing '(a << b) + c' when b is 0 is dumb, ADD should be used
>> instead.
>>
>> This fixes a compilation error with Alien Isolation because
>> src(1) is expected to be an immediate value, and the
>> replaceZero logic will transform 0 to $r63 (or $r255).
>>
> Just checking: does this replace or complement the patch by Karol?

It replaces.

> 
> FWIW this seems like the better solution, although I could be confused
> due to the longer commit message ;-)
> 
> Thanks,
> Emil
>