[Mesa-dev] [PATCH v2 2/6] radeonsi: make some si_descriptors fields 32-bit

Marek Olšák maraeo at gmail.com
Tue Aug 1 16:40:20 UTC 2017


Reviewed-by: Marek Olšák <marek.olsak at amd.com>

Marek

On Wed, Jul 26, 2017 at 4:21 PM, Samuel Pitoiset
<samuel.pitoiset at gmail.com> wrote:
> The number of bindless descriptors is dynamic and we definitely
> have to support more than 256 slots.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
> ---
>  src/gallium/drivers/radeonsi/si_state.h | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/gallium/drivers/radeonsi/si_state.h b/src/gallium/drivers/radeonsi/si_state.h
> index ec28abaf9a..c1fb5beef0 100644
> --- a/src/gallium/drivers/radeonsi/si_state.h
> +++ b/src/gallium/drivers/radeonsi/si_state.h
> @@ -235,7 +235,7 @@ struct si_descriptors {
>         /* The size of one descriptor. */
>         ubyte element_dw_size;
>         /* The maximum number of descriptors. */
> -       ubyte num_elements;
> +       uint32_t num_elements;
>
>         /* Offset in CE RAM */
>         uint16_t ce_offset;
> @@ -244,16 +244,16 @@ struct si_descriptors {
>          * range, direct uploads to memory will be used instead. This basically
>          * governs switching between onchip (CE) and offchip (upload) modes.
>          */
> -       ubyte first_ce_slot;
> -       ubyte num_ce_slots;
> +       uint32_t first_ce_slot;
> +       uint32_t num_ce_slots;
>
>         /* Slots that are used by currently-bound shaders.
>          * With CE: It determines which slots are dumped to L2.
>          *          It doesn't skip uploads to CE RAM.
>          * Without CE: It determines which slots are uploaded.
>          */
> -       ubyte first_active_slot;
> -       ubyte num_active_slots;
> +       uint32_t first_active_slot;
> +       uint32_t num_active_slots;
>
>         /* Whether CE is used to upload this descriptor array. */
>         bool uses_ce;
> --
> 2.13.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list