[Mesa-dev] [PATCH v2 01/17] swr/rast: threadID via portable std::this_thread::get_id()

Tim Rowley timothy.o.rowley at intel.com
Tue Aug 1 19:44:31 UTC 2017


Replace use of Win32 GetCurrentThreadId() with portable
std::this_thread::get_id().
---
 .../codegen/templates/gen_ar_eventhandlerfile.hpp    | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_ar_eventhandlerfile.hpp b/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_ar_eventhandlerfile.hpp
index 9017e8d..0ca9a78 100644
--- a/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_ar_eventhandlerfile.hpp
+++ b/src/gallium/drivers/swr/rasterizer/codegen/templates/gen_ar_eventhandlerfile.hpp
@@ -36,6 +36,7 @@
 #include "${event_header}"
 #include <fstream>
 #include <sstream>
+#include <thread>
 
 namespace ArchRast
 {
@@ -56,21 +57,22 @@ namespace ArchRast
             std::stringstream outDir;
             outDir << KNOB_DEBUG_OUTPUT_DIR << pBaseName << "_" << pid << std::ends;
             CreateDirectory(outDir.str().c_str(), NULL);
-
-            char buf[255];
+            
             // There could be multiple threads creating thread pools. We
             // want to make sure they are uniquly identified by adding in
             // the creator's thread id into the filename.
-            sprintf(buf, "%s\\ar_event%d_%d.bin", outDir.str().c_str(), GetCurrentThreadId(), id);
-            mFilename = std::string(buf);
+            std::stringstream fstr;
+            fstr << outDir.str().c_str() << "\\ar_event" << std::this_thread::get_id();
+            fstr << "_" << id << ".bin" << std::ends;
+            mFilename = fstr.str();
 #else
-            char buf[255];
             // There could be multiple threads creating thread pools. We
             // want to make sure they are uniquly identified by adding in
-            // the creator's thread (process) id into the filename.
-            // Assumes a 1:1 thread:LWP mapping as in linux.
-            sprintf(buf, "%s/ar_event%d_%d.bin", "/tmp", GetCurrentProcessId(), id);
-            mFilename = std::string(buf);
+            // the creator's thread id into the filename.
+            std::stringstream fstr;
+            fstr << "/tmp/ar_event" << std::this_thread::get_id();
+            fstr << "_" << id << ".bin" << std::ends;
+            mFilename = fstr.str();
 #endif
         }
 
-- 
2.7.4



More information about the mesa-dev mailing list