[Mesa-dev] [PATCH 11/13] radeonsi: fix streamout overflow predication on VI+

[Nicolai Hähnle]

On 01.08.2017 22:42, Marek Olšák wrote:
> On Thu, Jul 27, 2017 at 9:14 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>
>> There is a firmware regression that causes failures. Work around it by
>> using the compute shader for query_buffer_objects to summarize the query
>> results.
>> ---
>>   src/amd/common/r600d_common.h           |  1 +
>>   src/gallium/drivers/radeon/r600_query.c | 88 ++++++++++++++++++++++++++-------
>>   src/gallium/drivers/radeon/r600_query.h |  4 ++
>>   3 files changed, 75 insertions(+), 18 deletions(-)
>>
>> diff --git a/src/amd/common/r600d_common.h b/src/amd/common/r600d_common.h
>> index 3374475..bf3fe24 100644
>> --- a/src/amd/common/r600d_common.h
>> +++ b/src/amd/common/r600d_common.h
>> @@ -117,6 +117,7 @@
>>   #define PREDICATION_OP_CLEAR 0x0
>>   #define PREDICATION_OP_ZPASS 0x1
>>   #define PREDICATION_OP_PRIMCOUNT 0x2
>> +#define PREDICATION_OP_DX12 0x3
> 
> sid.h contains:
> 
> #define PREDICATION_OP_BOOL64 0x3
> 
> We should use the same name in both places. I'll leave the choice of
> the name up to you.

Ah yes, I was only looking in r600d_common.h. DX12 is the name in the 
internal docs, so I went with that, but BOOL64 makes more sense. I'll 
change it before pushing.

Cheers,
Nicolai

> 
> Marek
>