[Mesa-dev] [PATCH] pipe-loader: fix build of dynamic pipe-drivers

[Nicolai Hähnle]

On 03.08.2017 04:09, Michel Dänzer wrote:
> On 03/08/17 01:14 AM, Nicolai Hähnle wrote:
>> On 02.08.2017 18:04, Emil Velikov wrote:
>>> On 2 August 2017 at 16:29, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>>>> From: Nicolai Hähnle <nicolai.haehnle at amd.com>
>>>>
>>>> Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create
>>>> functions")
>>>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102014
>>> Seems like my s/flags/config->flags/ suggestion was way off.
>>>
>>> Thanks for the quick fix Nicolai
>>>
>>> Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
>>
>> Thanks, but Andy reported a follow-on build problem. It's annoying
>> because I don't have a working Clang/Clover setup, so I can't easily
>> test it.
> 
> Maybe it's time to fix that? :) I am building and testing clover, happy
> to help with any issues you run into with that.

Keeping both Clang and LLVM from trunk is extremely painful, mostly in 
terms of build times, but also for bisecting. That's why I gave that up 
at some point. Anyway, I'm testing the build with Travis now. Which also 
has a long turn-around time, but at least it doesn't block me from doing 
other things.

Cheers,
Nicolai

> 
> 
> I need this on top of your latest patch to fix the build, because
> si_driinfo.h is in the build directory:
> 
> diff --git a/src/gallium/targets/pipe-loader/Makefile.am b/src/gallium/targets/pipe-loader/Makefile.am
> index db492c5023..050dd7d9dc 100644
> --- a/src/gallium/targets/pipe-loader/Makefile.am
> +++ b/src/gallium/targets/pipe-loader/Makefile.am
> @@ -25,6 +25,7 @@ include $(top_srcdir)/src/gallium/Automake.inc
>   AM_CPPFLAGS = \
>          $(GALLIUM_CFLAGS) \
>          -I$(top_srcdir)/include \
> +       -I$(top_builddir)/src/gallium/drivers \
>          -I$(top_srcdir)/src/gallium/drivers \
>          -I$(top_srcdir)/src/gallium/winsys \
>          -I$(top_builddir)/src/util \
> 
> 
> 


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.