[Mesa-dev] [PATCH v2] pipe-loader: fix build of dynamic pipe-drivers

[Nicolai Hähnle]

On 02.08.2017 22:44, Jan Vesely wrote:
> probably. The original changeset passes NULL(which is then
> unconditionally accessed) at least in:
> 
> src/gallium/auxiliary/vl/vl_winsys_dri.c
> src/gallium/auxiliary/vl/vl_winsys_dri3.c
> src/gallium/auxiliary/vl/vl_winsys_drm.c
> src/gallium/state_trackers/xa/xa_tracker.c
> src/gallium/targets/d3dadapter9/drm.c
> src/gallium/tests/trivial/compute.c
> src/gallium/tests/trivial/quad-tex.c
> src/gallium/tests/trivial/tri.c
> 
> Not sure if the original idea was to handle NULL gracefully,
> but it looks like the change broke almost everything other than GL.

Yeah, my bad. I went back and forth on the interface a few times, but 
then didn't keep other state trackers up-to-date.

I'll have a patch for this shortly.

Cheers,
Nicolai


> 
> Jan
> 
> On Wed, 2017-08-02 at 21:28 +0100, Andy Furniss wrote:
>> Hmm, been AFK, but now have actually installed as well as just testing
>> build.
>>
>> Testing with this and the patch that avoids segfaults for cl.
>>
>> I am getting segfaults when using vdpau for video, so maybe that needs
>> something similar.
>>
>> Jan Vesely wrote:
>>> The patch still causes segfaults because you pass NULL at
>>> core/device.cpp:45
>>> yet unconditionally access the pointer at pipe_loader.c:130
>>>
>>> Jan
>>>
>>> On Wed, 2017-08-02 at 18:44 +0200, Nicolai Hähnle wrote:
>>>> Thanks! I'll take that as a Tested-by.
>>>>
>>>> On 02.08.2017 18:43, Andy Furniss wrote:
>>>>> Building OK with this.


-- 
Lerne, wie die Welt wirklich ist,
Aber vergiss niemals, wie sie sein sollte.