[Mesa-dev] [PATCH] i965: do not attempt fast clear with ISL_AUX_USAGE_NONE

[Jason Ekstrand]

On August 3, 2017 1:02:53 AM Tapani Pälli <tapani.palli at intel.com> wrote:

> Aux usage is ISL_AUX_USAGE_NONE when miptree is set shareable
> within (intel_miptree_make_shareable).
>
> Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101925
> ---
>  src/mesa/drivers/dri/i965/brw_blorp.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_blorp.c 
> b/src/mesa/drivers/dri/i965/brw_blorp.c
> index b2987ca..7483e7c 100644
> --- a/src/mesa/drivers/dri/i965/brw_blorp.c
> +++ b/src/mesa/drivers/dri/i965/brw_blorp.c
> @@ -791,6 +791,10 @@ do_single_blorp_clear(struct brw_context *brw, struct 
> gl_framebuffer *fb,
>         !brw_is_color_fast_clear_compatible(brw, irb->mt, &ctx->Color.ClearColor))
>        can_fast_clear = false;
>
> +   /* Aux surface usage has been disabled. */
> +   if (irb->mt->aux_usage == ISL_AUX_USAGE_NONE)
> +      can_fast_clear = false;

This should already be handled by the supports_fast_clear.  The fact that 
aux_usage and supports_fast_clear are getting out of sync is most likely 
the real problem.  I'll pull out a haswell today and see if I can reproduce it.

> +
>     /* Surface state can only record one fast clear color value. Therefore
>      * unless different levels/layers agree on the color it can be used to
>      * represent only single level/layer. Here it will be reserved for the
> --
> 2.9.4
>