[Mesa-dev] [PATCH 1/1] clover: Pass valid config structure to pipe_loader_create_screen

Aaron Watry awatry at gmail.com
Fri Aug 4 03:53:36 UTC 2017


Fixes a segfault when running clinfo on my r600 (BARTS/6850). Valgrind
led me straight to the same line.

Tested-by: Aaron Watry <awatry at gmail.com>


On Wed, Aug 2, 2017 at 1:15 PM, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> Fixes: Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions")
> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
> ---
> apply with the other build/link fixes
>
>  src/gallium/state_trackers/clover/core/device.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/state_trackers/clover/core/device.cpp b/src/gallium/state_trackers/clover/core/device.cpp
> index bd07670f38..0527c5713f 100644
> --- a/src/gallium/state_trackers/clover/core/device.cpp
> +++ b/src/gallium/state_trackers/clover/core/device.cpp
> @@ -42,7 +42,8 @@ namespace {
>
>  device::device(clover::platform &platform, pipe_loader_device *ldev) :
>     platform(platform), ldev(ldev) {
> -   pipe = pipe_loader_create_screen(ldev, NULL);
> +   struct pipe_screen_config config = {};
> +   pipe = pipe_loader_create_screen(ldev, &config);
>     if (!pipe || !pipe->get_param(pipe, PIPE_CAP_COMPUTE)) {
>        if (pipe)
>           pipe->destroy(pipe);
> --
> 2.13.3
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list