[Mesa-dev] [PATCH] anv/formats: Allow sampling on depth-only formats on gen7

Juan A. Suarez Romero jasuarez at igalia.com
Fri Aug 4 08:10:05 UTC 2017


On Thu, 2017-08-03 at 20:00 -0700, Jason Ekstrand wrote:
> We can't sample from depth-stencil formats but on gen7 but we can
> sample
> from depth-only formats.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102024
> ---


Reviewed-by: Juan A. Suarez Romero <jasuarez at igalia.com>

>  src/intel/vulkan/anv_formats.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/intel/vulkan/anv_formats.c
> b/src/intel/vulkan/anv_formats.c
> index c656d7e..9808508 100644
> --- a/src/intel/vulkan/anv_formats.c
> +++ b/src/intel/vulkan/anv_formats.c
> @@ -395,7 +395,8 @@ anv_physical_device_get_format_properties(struct
> anv_physical_device *physical_d
>        /* Nothing to do here */
>     } else if (vk_format_is_depth_or_stencil(format)) {
>        tiled |= VK_FORMAT_FEATURE_DEPTH_STENCIL_ATTACHMENT_BIT;
> -      if (physical_device->info.gen >= 8)
> +      if (vk_format_aspects(format) == VK_IMAGE_ASPECT_DEPTH_BIT ||
> +          physical_device->info.gen >= 8)
>           tiled |= VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT;
>  
>        tiled |= VK_FORMAT_FEATURE_BLIT_SRC_BIT |


More information about the mesa-dev mailing list